Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dereference $rebuild_args because it is a reference to an array #5412

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

eseyman
Copy link

@eseyman eseyman commented Jan 27, 2025

$rebuild_args needs to be dereferenced when used in a join because it is a reference to an array. This is done when the script is executed with a non-root user (line 359) but not when called with root.

Community contributors

eseyman

Description

Here, $rebuild_args needs to be dereferenced when used in a join because it is a reference to an array. This is done when the script is executed with a non-root user (line 359) but not when called with root.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched.
Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.
To integrate this pull request into our core we need to add some automated tests to check the proper
functioning of this PR. Ideally we need the following informations:

  • SNMP: MIB files and full snmpwalk of enterprise branch (snmpwalk -ObentU -v 2c -c public address .1.3.6.1.4.1 > equipment.snmpwalk) or SNMP collections.
  • HTTP API (SOAP, Rest/Json, XML-RPC): the documentation and some curl examples (command with -v + output) or HTTP collections.
  • CLI: command line examples (command + result).
  • SQL: queries + results + column types or SQL collections.
  • JMX: mbean names and attributes.

If some information is confidential, such as logins or IP addresses, obfuscate them in what is sent
publicly and we'll get in touch with you by private message if this information is needed.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • I have provide data or shown output displaying the result of this code in the plugin area concerned.

$rebuild_args needs to be dereferenced when used in a join because it is
a reference to an array. This is done when the script is executed with a
non-root user (line 359) but not when called with root.
@eseyman eseyman requested a review from a team as a code owner January 27, 2025 16:30
@eseyman eseyman requested a review from Evan-Adam January 27, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants